Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: short-circuit code login on two step card #248

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix: short-circuit code login on two step card #248

merged 1 commit into from
Oct 24, 2024
+68 −20

Conversation

jonas-jonas
Copy link
Member

@jonas-jonas jonas-jonas commented Oct 23, 2024 •
edited
Loading

Screen.Recording.2024-10-23.at.8.41.17.PM.mov

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Oct 23, 2024
@jonas-jonas jonas-jonas force-pushed the jonas-jonas/fixDoubleSubmitCode branch from 69495a9 to 37a9bd8 Compare October 23, 2024 18:57
@codecov Codecov
Copy link

codecov bot commented Oct 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 28.57143% with 15 lines in your changes missing coverage. Please review.

Project coverage is 51.53%. Comparing base (d719e15) to head (f9f26d4).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ements-react/src/components/card/card-two-step.tsx 18.75% 13 Missing ⚠️
...ckages/elements-react/src/components/form/form.tsx 50.00% 1 Missing ⚠️
...ges/elements-react/src/theme/default/utils/form.ts 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   51.95%   51.53%   -0.43%     
==========================================
  Files         103      104       +1     
  Lines         995     1009      +14     
  Branches      122      125       +3     
==========================================
+ Hits          517      520       +3     
- Misses        473      484      +11     
  Partials        5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonas-jonas jonas-jonas force-pushed the jonas-jonas/fixDoubleSubmitCode branch from 37a9bd8 to f9f26d4 Compare October 24, 2024 07:43
@jonas-jonas jonas-jonas merged commit 66ecfb7 into main Oct 24, 2024
6 of 12 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/fixDoubleSubmitCode branch October 24, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszekiel mszekiel mszekiel approved these changes

Assignees

@jonas-jonas jonas-jonas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonas-jonas @mszekiel